Skip to content

Commit 754d697

Browse files
y-novikovCommit Bot
authored and
Commit Bot
committed
Ignore FreeAllocationOnTimestamp GL debug message
Erroneously produced by Android Q Qualcomm driver for worker contexts. Bug: angleproject:3491 Change-Id: I8f2a5f05ad8a00c97d0dfa6e3b7a939d05656420 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1700255 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
1 parent 5de073c commit 754d697

File tree

1 file changed

+23
-0
lines changed

1 file changed

+23
-0
lines changed

src/libANGLE/renderer/gl/RendererGL.cpp

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,14 @@ void SetMaxShaderCompilerThreads(const rx::FunctionsGL *functions, GLuint count)
7070
}
7171
}
7272

73+
#if defined(ANGLE_PLATFORM_ANDROID)
74+
const char *kIgnoredErrors[] = {
75+
// Wrong error message on Android Q Pixel 2. http://anglebug.com/3491
76+
"FreeAllocationOnTimestamp - Reference to buffer created from "
77+
"different context without a share list. Application failed to pass "
78+
"share_context to eglCreateContext. Results are undefined.",
79+
};
80+
#endif // defined(ANGLE_PLATFORM_ANDROID)
7381
} // namespace
7482

7583
static void INTERNAL_GL_APIENTRY LogGLDebugMessage(GLenum source,
@@ -155,6 +163,21 @@ static void INTERNAL_GL_APIENTRY LogGLDebugMessage(GLenum source,
155163
break;
156164
}
157165

166+
#if defined(ANGLE_PLATFORM_ANDROID)
167+
if (type == GL_DEBUG_TYPE_ERROR)
168+
{
169+
for (const char *&err : kIgnoredErrors)
170+
{
171+
if (strncmp(err, message, length) == 0)
172+
{
173+
// There is only one ignored message right now and it is quite spammy, around 3MB
174+
// for a complete end2end tests run, so don't print it even as a warning.
175+
return;
176+
}
177+
}
178+
}
179+
#endif // defined(ANGLE_PLATFORM_ANDROID)
180+
158181
if (type == GL_DEBUG_TYPE_ERROR)
159182
{
160183
ERR() << std::endl

0 commit comments

Comments
 (0)