Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add an extra step to detail Docker environment clean up #48

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add an extra step to detail Docker environment clean up #48

wants to merge 6 commits into from

Conversation

mjbear
Copy link
Contributor

@mjbear mjbear commented Sep 25, 2024 •
edited
Loading

Summary

Add steps to detail cleaning up the Docker environment (stop container, delete image).

These courses are great and offer a low barrier of entry for beginners. Since beginners can work through this course it is a good idea to also include how to stop the Docker container and also remove the image when we're done with it.

Changes

  • Adds a Step 6 markdown file
  • Modifies the third Actions workflow file to include Step 6 markdown content
  • Modifies the Step 1 markdown file to emphasize the cd repo with inline code tags (as seen to the left)
    • (This matches the style convention in later Step markdown files.)

Closes: #47

Task list

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

@mjbear
Create 6-clean-up-docker.md
a17d5c0
@mjbear
Update 3-merge-your-pull-request.yml to add step 6
ab1558d 
Add step 6 to workflow
@mjbear
Update 3-merge-your-pull-request.yml - update to_step
3539352 
Update the most important part of to_step!
@mjbear
Update 6-clean-up-docker.md - indent to continue the numbering
c19384e 
Further indent to continue the ordered bullet numbering
@mjbear
Update 6-clean-up-docker.md - singular words
73ab9fb 
In the Step 6 heading, change containers and images to be singular.
@mjbear mjbear mentioned this pull request Sep 25, 2024
Open
@mjbear
Update 1-create-the-workflow-file.md - emphasize the cd branch text
c1fef12 
Use inline code tags like other steps in this course to emphasize the cd branch
@mjbear
Copy link
Contributor Author

mjbear commented Sep 25, 2024 •
edited
Loading

I performed testing via this temporary repo: https://github.com/mjbear/test_skills-publish-packages
(Once this is evaluated and hopefully merged, I plan on deleting that "test" repo.) 😀

Is there an simple way to test the Actions workflow?

(As compared to creating a new branch new_main, merging my feature branch into that, renaming main to old_main, and then renaming new_main to main. And cloning the template repo to manually go through the workflow. And then setting the default repo to be main again. 😅 )

@mjbear mjbear marked this pull request as ready for review September 25, 2024 13:24
@nguyenalex836
Copy link

@mjbear Thank you for submitting this PR! ✨

Would it make sense on the X-finish.md step to link to the MS Learn Introduction to Docker containers module?

I'll get this triaged for review, and the team can address this Q from your linked issue during their review 💛

@mjbear
Copy link
Contributor Author

mjbear commented Oct 1, 2024

@mjbear Thank you for submitting this PR! ✨

Would it make sense on the X-finish.md step to link to the MS Learn Introduction to Docker containers module?

I'll get this triaged for review, and the team can address this Q from your linked issue during their review 💛

I've been full of PRs lately 🤣 ... yeah, there's a few others against this repo

@mjbear
Copy link
Contributor Author

mjbear commented Oct 1, 2024

@nguyenalex836
If you and your team think the MS Learn article would be good to link to, I will add that modification to this PR and y'all can merge away.

Thank you! 💚

@heiskr heiskr requested a review from a team October 10, 2024 16:35
@mjbear
Copy link
Contributor Author

mjbear commented Nov 22, 2024

I'm curious to learn of any feedback.
Thank you all!

@nguyenalex836
Copy link

Howdy @mjbear, good to hear from you! 👋 I see this has been assigned to our content team for review - they'll be sure to update you here as soon as they've finished reviewing 💛

We appreciate your patience - thank you so much for contributing to GitHub Skills! ✨

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sinsukehlab sinsukehlab sinsukehlab approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Add steps for cleaning up the Docker environment
3 participants
@mjbear @nguyenalex836 @sinsukehlab