Missing "routes/custom-host" resource in ClusterRole

[trumbaut]

Skupper allows setting a hostname for routes using the data:ingress-host parameter in the skupper-site ConfigMap. However, currently this doesn't work in OCP (skupper-operator.v1.2.2-74cbf46bbc) due to missing ClusterRole permissions. As a result, setting the data:ingress-host parameter breaks initialising the site with following errors in the site controller pod:

2023/04/07 09:49:53 Initialising skupper site ...
2023/04/07 09:49:54 Error initialising skupper: Route.route.openshift.io "skupper-inter-router" is invalid: spec.host: Forbidden: you do not have permission to set the host field of the route
E0407 09:49:54.785647 1 controller.go:168] Route.route.openshift.io "skupper-inter-router" is invalid: spec.host: Forbidden: you do not have permission to set the host field of the route

To fix this, we simply need to add routes/custom-host as a resource for the ClusterRole (https://github.com/skupperproject/skupper-operator/blob/main/bundle/manifests/1.3.0/skupper-operator.v1.3.0.clusterserviceversion.yaml#L68):

[...]
        - apiGroups:
          - route.openshift.io
          resources:
          - routes
          - routes/custom-host
          verbs:
[...]

Let me know if/where I can create a PR for this.

[fgiorgetti]

@trumbaut makes sense to me.
@grs @ajssmith @nluaces thoughts?

[grs]

Yes, makes sense to me also

[fgiorgetti]

@trumbaut could you please submit a PR with the proposed change?
You have to do it against the Skupper repository.

[trumbaut]

@fgiorgetti : I fixed this in trumbaut@ef56c2d but how can I submit it against the Skupper repository?

[fgiorgetti]

@trumbaut you can send the operator PR, of course.
On the Skupper (repo) we need to add this extra resource at api/types/types.go

[trumbaut]

@fgiorgetti, please check the PR's above.