Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bug in Flow Collector allows it to update skupper-network-status #1406

Closed
c-kruse opened this issue Feb 28, 2024 · 0 comments · Fixed by #1405
Closed

Bug in Flow Collector allows it to update skupper-network-status #1406

c-kruse opened this issue Feb 28, 2024 · 0 comments · Fixed by #1405

Comments

@c-kruse
Copy link
Contributor

c-kruse commented Feb 28, 2024

Describe the bug
The flow collector does not check that it is in the right mode before calling updateNetworkStatus in one location, and causes the flow-collector process to compete with the config-sync process to update the skupper-network-status configmap.

I believe this affects v1.5.0+

How To Reproduce
skupper init --enable-console --enable-flow-collector

Expected behavior
Not this.

Additional context
I do not believe that the flow collector is in any worse position to be the one updating this map, so I can understand why it's taken so long to uncover the issue. Recently I added some logging around this update - which is helpful to confirm the issue. I was only able to uncover it because the unit tests were mangling the network status of the skupper site in my active kubeconfig context.

$ k logs deployments/skupper-service-controller -c flow-collector | grep "network status update"
2024/02/27 19:57:02 COLLECTOR: First functional network status update written after 12.130744504s and 3 updates
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant