Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[v2] Set annotations on loadbalancer services #1900

Open
calvinbui opened this issue Jan 22, 2025 · 3 comments
Open

[v2] Set annotations on loadbalancer services #1900

calvinbui opened this issue Jan 22, 2025 · 3 comments
Assignees

Comments

@calvinbui
Copy link

calvinbui commented Jan 22, 2025

Describe the bug

I need to be able to set annotations on the skupper-grant-server and skupper-router-1 services that the skupper-controller and skupper-router creates.

On AWS EKS all LB services are private by default unless the right annotations are set to make it public.

Environment details

  • Skupper CLI: [e.g. 1.5.0, 1.4.3] 2.0.0-preview-2
  • Platform: [e.g kubernetes, openshift] kubernetes (eks)

Additional context

I can add the annotations afterwards, but it also requires deleting all the certificates and restarting the controller.

@calvinbui calvinbui changed the title [v2] Set annotations on skupper-grant-server service [v2] Set annotations on loadbalancer services Jan 22, 2025
@grs grs self-assigned this Jan 22, 2025
@grs
Copy link
Member

grs commented Jan 23, 2025

Thank you for trying out v2 and submitting this issue!

One solution is to not use -grant-server-autoconfigure on the controller and instead create the service to expose the controller yourself (with any annotations desired), and then use the corresponding ip or hostname in setting the -grant-server-base-url.

I believe we can do better though and will give some thought to different options to allow annotations to be controlled.

@calvinbui
Copy link
Author

Thank you for trying out v2 and submitting this issue!

One solution is to not use -grant-server-autoconfigure on the controller and instead create the service to expose the controller yourself (with any annotations desired), and then use the corresponding ip or hostname in setting the -grant-server-base-url.

I believe we can do better though and will give some thought to different options to allow annotations to be controlled.

What about the router?

@grs
Copy link
Member

grs commented Jan 23, 2025

What about the router?

I will address that also.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants