Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

When parsing a dbc file, all signal properties are str #4

Open
tpimh opened this issue May 10, 2023 · 0 comments
Open

When parsing a dbc file, all signal properties are str #4

tpimh opened this issue May 10, 2023 · 0 comments

Comments

@tpimh
Copy link

tpimh commented May 10, 2023

Hi! Thanks for your library, I'm now using it to parse a DBC file and discovered that almost all the numeric values are all parsed as strings.

The values for start_bit and sig_len are parsed correctly as integers, but factor, offset, min and max are all str type. I think the reason for this is that these values can be either floats or integers. One way to dynamically select between the two would be to check if the value has a dot:

def int_or_float(n):
    return float(n) if '.' in n else int(n)
sig.factor = int_or_float(line_split[5])
sig.offset = int_or_float(line_split[6])
sig.min = int_or_float(line_split[7])
sig.max = int_or_float(line_split[8])
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant