You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is there some rules about names? In MergeIterator you use create, but in LsmIterator and FusedIterator you use new.
Is there some rules about returning a type or result? LsmIterator::new() returns Result<Self>, but MergeIterator::create() and FusedIterator::new() return Self.
I implement a new range iterator that accepts Range like 1..10 rather than (Bound, Bound). I have to add new struct in mem_table.rs and lsm_iterators.rs.
In mem_table.rs, crossbeam_skiplist::map::Range<'this, Bytes, Range<Bytes>, Bytes, Bytes> to replace old SkipMapRangeIter<'this>.
In lsm_iterators.rs, you specify MergeIterator<MemTableIterator> rather than use generic. That's why I have to add new duplicated code.
Is there any reasons why you don't use generic? Is there any better ways to add a range iterator?
The text was updated successfully, but these errors were encountered:
MergeIterator
you usecreate
, but inLsmIterator
andFusedIterator
you usenew
.LsmIterator::new()
returnsResult<Self>
, butMergeIterator::create()
andFusedIterator::new()
returnSelf
.Range
like1..10
rather than(Bound, Bound)
. I have to add new struct inmem_table.rs
andlsm_iterators.rs
.In
mem_table.rs
,crossbeam_skiplist::map::Range<'this, Bytes, Range<Bytes>, Bytes, Bytes>
to replace oldSkipMapRangeIter<'this>
.In
lsm_iterators.rs
, you specifyMergeIterator<MemTableIterator>
rather than use generic. That's why I have to add new duplicated code.Is there any reasons why you don't use generic? Is there any better ways to add a range iterator?
The text was updated successfully, but these errors were encountered: