Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add whitelisted players count #176

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Add whitelisted players count #176

merged 2 commits into from
Jan 12, 2023

Conversation

weihao
Copy link
Contributor

@weihao weihao commented Jan 7, 2023

Notes

  • Added optional whitelisted players count
  • Added a new diagnostic dashboard

sladkoff
sladkoff reviewed Jan 11, 2023
View reviewed changes
Copy link
Owner

@sladkoff sladkoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

src/main/java/de/sldk/mc/config/PrometheusExporterConfig.java Outdated Show resolved Hide resolved
@weihao @sladkoff
Update src/main/java/de/sldk/mc/config/PrometheusExporterConfig.java
d725aa4 
Co-authored-by: Leonid Koftun <leonid.koftun@gmail.com>
@weihao
Copy link
Contributor Author

weihao commented Jan 12, 2023 •
edited
Loading

Agreed, the whitelisted player count should be optional metrics and collection is off by default

@sladkoff sladkoff merged commit e081774 into sladkoff:master Jan 12, 2023
@weihao weihao deleted the pr-1 branch January 12, 2023 18:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sladkoff sladkoff sladkoff left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weihao @sladkoff