Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CLJS improper exception handling #122

Closed
slagyr opened this issue Mar 9, 2015 · 2 comments
Closed

CLJS improper exception handling #122

slagyr opened this issue Mar 9, 2015 · 2 comments
Labels
bug

Comments

@slagyr
Copy link
Owner

slagyr commented Mar 9, 2015

Specs that throw an ex-info are counted as failures but should be errors
Specs that throw a js/Error are counted as failure too.
Specs that a string abort the test run.
@slagyr slagyr added the bug label Mar 9, 2015
@slagyr
Copy link
Owner Author

slagyr commented Mar 9, 2015

CLJ specs exhibit the same behavior. SpecFailures are not distinguished from other exceptions.

@slagyr
Copy link
Owner Author

slagyr commented Mar 9, 2015

Doh! I looks like convention is to treat errors like failures except in compilation/parse errors.

@slagyr slagyr closed this as completed Mar 9, 2015
@slagyr slagyr reopened this Mar 9, 2015
@slagyr slagyr closed this as completed in 8214241 Mar 9, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@slagyr