Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Paged lists stop loading new items after the screen gets rotated #1194

Closed
Fs00 opened this issue Apr 7, 2022 · 1 comment
Closed

Paged lists stop loading new items after the screen gets rotated #1194

Fs00 opened this issue Apr 7, 2022 · 1 comment

Comments

@Fs00
Copy link
Contributor

Fs00 commented Apr 7, 2022

I've encountered a bug in all paged lists (releases list, commits list, stargazers list... actually all those inheriting from PagedDataBaseFragment) caused by screen rotation.
Basically, after the user rotates the screen, scrolling at the bottom of the paged list doesn't trigger the loading of the next page. The Loading... indicator is shown but nothing happens.

@maniac103
Copy link
Collaborator

Initial inspection shows this is due to RxLoader not subscribing to the upstream observable if it can deliver a previously loaded value, which is why mPageSubject.onNext(mNextPage) becomes a no-op because mPageSubject does not have any observers.
Not sure about the correct fix though...

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants