From c8b96bf0160663575f99fb02c041b47046c89c12 Mon Sep 17 00:00:00 2001 From: Jayapriya Pai Date: Wed, 23 Feb 2022 20:30:17 +0530 Subject: [PATCH] jsonnet/main.jsonnet: Override containerfsSelector container_fs_.* metrics doesn't have "container" label after openshift/cluster-monitoring-operator/pull/1402 which caused regression for dashboards using "container" label since it gives empty datapoints for all queries using "container" label in queries containing container_fs_.* metrices. Inorder to fix the dashboards added containerfsSelector in kubernetes-monitoring/kubernetes-mixin/pull/737 and overrided the containerfsSelector default value from container!="" to harmless id!="" in this commit. We really don't need that selector since we dropped the container label in OCP for container_fs_.* metrices but we need to override the selector for the queries involving container_fs_.* to work. --- jsonnet/main.jsonnet | 1 + 1 file changed, 1 insertion(+) diff --git a/jsonnet/main.jsonnet b/jsonnet/main.jsonnet index 05f370b974..11c8610e51 100644 --- a/jsonnet/main.jsonnet +++ b/jsonnet/main.jsonnet @@ -360,6 +360,7 @@ local inCluster = cpuThrottlingSelector: $.values.common.mixinNamespaceSelector, kubeletPodLimit: 250, pvExcludedSelector: 'label_alerts_k8s_io_kube_persistent_volume_filling_up="disabled"', + containerfsSelector: 'id!=""', }, }, },