Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

RouteParser is not always present #2983

Closed
l0gicgate opened this issue Jul 8, 2020 · 1 comment · Fixed by #3022
Closed

RouteParser is not always present #2983

l0gicgate opened this issue Jul 8, 2020 · 1 comment · Fixed by #3022
Milestone

Comments

@l0gicgate
Copy link
Member

When the RoutingMiddleware is automatically instantiated by the RouteRunner because routing was not performed:
https://github.com/slimphp/Slim/blob/4.x/Slim/Routing/RouteRunner.php#L72

It calls performRouting but that means it doesn't append the RouteParser via this call since process is never called:
https://github.com/slimphp/Slim/blob/4.x/Slim/Middleware/RoutingMiddleware.php#L58

We need to fix this by moving that line into the performRouting method.

@l0gicgate l0gicgate added this to the 4.6.0 milestone Jul 8, 2020
@l0gicgate
Copy link
Member Author

@adriansuter I tried reaching out to you via Slack but it doesn't look like you've been active. Is there a way for me to direct message you somewhere else? I have something to ask you.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant