Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Style: Remove trailing whitespace via pre-commit rule #2976

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

connortann
Copy link
Collaborator

@connortann connortann commented Jun 5, 2023

Incremental progress towards standard code style.

This PR adds the buitin "trailing-whitespace" pre-commit hook to pyproject.toml, and applies the hook to the rest of the repo.

This PR has no functional changes, despite the large number of changes lines. In future, this should help keep diffs minimal.

@connortann connortann changed the title Style: Remove trailing whitespace Style: Remove trailing whitespace via pre-commit rule Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #2976 (e8fefba) into master (4fc78ed) will not change coverage.
The diff coverage is 11.66%.

@@           Coverage Diff           @@
##           master    #2976   +/-   ##
=======================================
  Coverage   54.61%   54.61%           
=======================================
  Files          90       90           
  Lines       12878    12878           
=======================================
  Hits         7033     7033           
  Misses       5845     5845           
Impacted Files Coverage Δ
shap/actions/_action.py 60.00% <ø> (ø)
shap/benchmark/__init__.py 0.00% <ø> (ø)
shap/benchmark/_compute.py 0.00% <ø> (ø)
shap/benchmark/_sequential.py 0.00% <0.00%> (ø)
shap/benchmark/experiments.py 0.00% <0.00%> (ø)
shap/benchmark/framework.py 0.00% <0.00%> (ø)
shap/benchmark/measures.py 0.00% <ø> (ø)
shap/benchmark/methods.py 0.00% <ø> (ø)
shap/benchmark/metrics.py 0.00% <ø> (ø)
shap/benchmark/models.py 0.00% <ø> (ø)
... and 31 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@connortann connortann force-pushed the style/trailing-whitespace-hook branch from a390f6d to 3820992 Compare June 5, 2023 16:18
@connortann connortann requested a review from dsgibbons June 5, 2023 16:19
@connortann connortann added this to the 2023-06-fixes milestone Jun 5, 2023
@connortann connortann force-pushed the style/trailing-whitespace-hook branch from 3820992 to e8fefba Compare June 5, 2023 18:30
Copy link
Collaborator

@dsgibbons dsgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dsgibbons dsgibbons merged commit b2a60a3 into master Jun 5, 2023
@connortann connortann deleted the style/trailing-whitespace-hook branch June 6, 2023 08:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants