-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: heatmap plot colorbar and internal refactoring #3040
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3040 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 90 90
Lines 12855 12850 -5
======================================
+ Misses 12855 12850 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
75b3beb
to
0e3c936
Compare
0e3c936
to
e2755be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! There are several notices from Codecov about patches not covered by tests, as the code coverage is not currently being reported correctly. I'll see if I can look in to that tomorrow.
Failing tests are from pytorch mnist cnn, irrelevant to the changes in this PR. See #2960 |
Overview
Description of the changes proposed in this pull request:
shap.plots.heatmap
, see:ax
-based implementation instead ofplt.imshow()
,plt.barh()
etc.; primarily so we don't have to dopl.gca()
all over the place, and also the axes is needed to pass intoplt.colorbar()
to avoid warnings aboutpytest-mpl
using the "classic" matplotlib style; anybody with a more recent matplotlib version should already have the tick directions being "out" even prior to this PR. I only made this explicit in-code so that the baseline images generated bypytest-mpl
reflects what most users would get by default ("out" tick directions).f(x)
text in MathTex rather than plain text to match with the force plots.Checklist
CHANGELOG.md
(if changes will affect users)