Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Synchronized sub file is being stripped clean #30

Closed
MisterKurtz10 opened this issue May 8, 2019 · 5 comments
Closed

Synchronized sub file is being stripped clean #30

MisterKurtz10 opened this issue May 8, 2019 · 5 comments
Assignees
Labels
duplicate This issue or pull request already exists

Comments

@MisterKurtz10
Copy link

MisterKurtz10 commented May 8, 2019

I'm getting a screen like this

https://imgur.com/e41aL1Z

and the output file has a single entry.

@smacke
Copy link
Owner

smacke commented May 9, 2019

Hard to say more here without the video and subtitles file. The issue is that it is computing a nonsensical value for the optimal offset. I can try to find 28 days later and see what is going on in more detail, if give me a link to the subtitles.

Repository owner deleted a comment from MisterKurtz10 May 15, 2019
@smacke
Copy link
Owner

smacke commented May 15, 2019

I went ahead and deleted your comment with the link but will be running some tests to figure out what is going on shortly. Thanks!

@smacke smacke added the duplicate This issue or pull request already exists label May 21, 2019
@smacke
Copy link
Owner

smacke commented May 21, 2019

Hi @MisterKurtz10, it looks to me like this is part of a bigger issue related to current limitations of this project. Right now subsync corrects fixed drift. This can occur, for example, if your video cuts out an intro but your subs don't (or vice versa). Despite these limitations, this handles the majority of cases pretty well. Your video is one of the exceptions -- it has a pause of some sort in the middle somewhere not present in the subs, and so the correction algorithm is barfing. I'm currently thinking about how to fix this in #10 but it will take some time I'm afraid. I'll leave this issue open so I remember to test with your video / subs once I have a working algorithm.

@smacke smacke self-assigned this May 21, 2019
@MisterKurtz10
Copy link
Author

Thanks for looking at it. I'll try it on other files and see if my luck improves.

@smacke
Copy link
Owner

smacke commented Mar 12, 2020

Hi @MisterKurtz10 good news! This is now fixed in the latest stable version which can be installed as follows:
pip install git+https://github.com/smacke/subsync@STABLE

The issue ended up being that the movie and subs were at different frame rates, which is now a case we handle properly.

I know it's been quite a while, but please consider taking another look at this project the next time you have out-of-sync subs -- the latest improvements include better character encoding detection, frame rate scaling, and support for SSA/ASS, with even more improvements planned...

@smacke smacke closed this as completed Mar 12, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants