Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Emoji Logic Deprecation Warning #103

Closed
BalzaniEdoardo opened this issue Sep 25, 2024 · 2 comments · Fixed by #104
Closed

Emoji Logic Deprecation Warning #103

BalzaniEdoardo opened this issue Sep 25, 2024 · 2 comments · Fixed by #104

Comments

@BalzaniEdoardo
Copy link
Contributor

Hi, thanks for the awesome package!

mkdcos-material is raising a deprecation warning:

          Material emoji logic has been officially moved into mkdocs-material
          version 9.4. Please use Material's 'material.extensions.emoji.twemoji'
          instead of 'materialx.emoji.twemoji' in your 'mkdocs.yml' file.
          
           ```
           markdown_extensions:
             - pymdownx.emoji:
                 emoji_index: !!python/name:material.extensions.emoji.twemoji
                 emoji_generator: !!python/name:material.extensions.emoji.to_svg
           ```

However in the src/mkdocs-gallery/plugin.py, the deprecated configuration is set, line 226-228 of that script.

This result in a warning when building the docs.

Replacing those lines with,

- pymdownx.emoji:
                 emoji_index: !!python/name:material.extensions.emoji.twemoji
                 emoji_generator: !!python/name:material.extensions.emoji.to_svg

would fix the warning. Is there a reason you did not update the config yet?

Best regards,
Edoardo

@smarie
Copy link
Owner

smarie commented Sep 25, 2024

Thanks @BalzaniEdoardo ! Indeed this should have been done already ! The "only" reason is probably (?) because this warning appeared after the last release ? But I'm not actually even sure.

Would you like to propose a small PR ? If so, please add a new changelog section with an item mentioning your PR. Thanks !

@BalzaniEdoardo
Copy link
Contributor Author

Absolutely!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants