SDL must close only session in case mobile app does not answer on Heartbeat_request

[LitvinenkoIra]

Occurrence:

Always

Steps to reproduce:

1. Reduce default value for Heartbeat timeout in SDL .INI file to 5 sec.
2. Start SDL
3. Start HMI
4. Connect mobile device
5. Register mobile application (sending of Heartbeat from application is switched off)
6. Wait 15 seconds
7. Check that app is unregistered
8. Check that mobile connection is still alive

Expected result:

Mobile connection is still alive and it's possible to create new mobile session

Actual result:

Mobile connection is closed

Environment:

Test script:

1893_ATF_HeartBeat_App_does_not_send_HB_and_does_not_respond.lua

Expected delivery

• Source code updates
• Code comments
• UTs add/update (not required)
• ATF tests add/update
• Manual tests (not required)
• Add/update CI plans/jobs (not required)
• SDD updates (not required)
• Guidelines update (sdl_core_guides) (not required)
• Guidelines update (sdl_hmi_integration_guidelines) (not required)

[aderiabin]

Contributor priority is set High with reason: The issue is related to connection/session logic
Mobile applications should work independently one from other.

[LitvinenkoIra]

Works correctly on current develop (8c94933)
Script for verifying and testing report 1893.tar.gz

[LuxoftAKutsan]

@jacobkeeler @JackLivio please close the issue.

[LuxoftAKutsan]

HeartBeatMonitor is in charge of monitoring heartbeat timeout. There is separate HeartBeatMonitor for each connection.
It has separate own thread that executing HeartBeatMonitor::Process function.
HeartBeatMonitor handles session numbers and monitors heartbeat for each session :

class HeartBeatMonitor : public threads::ThreadDelegate {
...
  HeartBeatMonitor(uint32_t heartbeat_timeout_mseconds, Connection* connection);

  void AddSession(uint8_t session_id);
  void RemoveSession(uint8_t session_id);
...

void HeartBeatMonitor::Process() {
  sessions_list_lock_.Acquire();
  SessionMap::iterator it = sessions_.begin();
  while (it != sessions_.end()) {
  ...

And in case if Hearbeat timeout elapsed HeartBeatMonitor will close certain session :

void HeartBeatMonitor::Process() {
...
    if (state.HasTimeoutElapsed()) {
      const uint8_t session_id = it->first;
      if (state.IsReadyToClose()) {
        LOG4CXX_WARN(logger_, "Will close session");
        sessions_list_lock_.Release();
        RemoveSession(session_id);
        connection_->CloseSession(session_id);
        sessions_list_lock_.Acquire();
...
}

[dboltovskyi]

There is some extension for the initial requirement:
SDL should not close mobile connection even if last session on this connection had been closed.

Currently on a head of develop (0b19cf4) SDL close such connection, so issue is reproduced.

Description of the issue is updated.
Test script is also updated accordingly.

[mrapitis]

Requires additional testing with the updated script that is provided.

[GetmanetsIrina]

Defect is reproduced on develop branch(0b19cf4).
Fix in #1965,
ATF version for verification https://github.com/smartdevicelink/sdl_atf/commits/develop(ae3c97da2ca77031b645773917b63eff1421c04d) with HB fix,
script for verification https://github.com/smartdevicelink/sdl_atf_test_scripts/blob/develop/test_scripts/Defects/4_5/1893_ATF_HeartBeat_App_does_not_send_HB_and_does_not_respond.lua.