Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Memory leaks in media_manager_test unit tests #2274

Closed
shoamano83 opened this issue Jun 18, 2018 · 2 comments
Closed

Memory leaks in media_manager_test unit tests #2274

shoamano83 opened this issue Jun 18, 2018 · 2 comments

Comments

@shoamano83
Copy link
Contributor

Bug Report

Memory leaks are observed when media_manager_test is executed under valgrind.

Reproduction Steps
  1. Check out commit 1527db9 from develop branch
  2. Give a build with cmake ../sdl_core -DBUILD_TESTS=ON and make
  3. under src/components/media_manager/test directory, run valgrind --trace-children=yes --leak-check=full ./media_manager_test > media_manager_test_valgrind.txt 2>&1
Expected Behavior

Memory leaks should not be observed.

Observed Behavior

Valgrind reports several memory leaks. Please refer to attached log files.

OS & Version Information
  • OS/Version: Ubuntu 16.04 (amd64)
  • SDL Core Version: Commit 1527db9 from develop branch
  • Testing Against: N/A (unit testing)
Test Case, Sample Code, and / or Example App

Valgrind log is attached: media_manager_test_valgrind.txt

@shoamano83
Copy link
Contributor Author

shoamano83 commented Jun 18, 2018

I fixed the issue and found that the root cause was an inappropriate implementation of unit test code. This is not an issue of SDL Core, so the priority may be low.

I also see several invalid memory access issues in the valgrind log. These will be fixed with PR #2178 (commit f683de3).

@jacobkeeler
Copy link
Contributor

Closing with the merge of #2275

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants