Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove class check for actualLanguage in the SDLLifecycleManager #1218

Closed
NicoleYarroch opened this issue Apr 4, 2019 · 0 comments
Closed

Remove class check for actualLanguage in the SDLLifecycleManager #1218

NicoleYarroch opened this issue Apr 4, 2019 · 0 comments
Assignees
@justingluck93
Labels
best practice Not a defect but something that should be improved anyway
Milestone
6.2.0

Comments

@NicoleYarroch
Copy link
Contributor

Bug Report

Remove class check for actualLanguage in the SDLLifecycleManager. The check was added in PR #1128, but is no longer an issue with the merge of PR #1199, which verifies the type of a returned object.

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: 6.2
  • Testing Against: n/a
@NicoleYarroch NicoleYarroch added the best practice Not a defect but something that should be improved anyway label Apr 4, 2019
@justingluck93 justingluck93 self-assigned this Apr 5, 2019
@justingluck93 justingluck93 mentioned this issue Apr 5, 2019
Merged
1 task
@joeljfischer joeljfischer added this to the 6.2.0 milestone Apr 5, 2019
@joeljfischer joeljfischer mentioned this issue Apr 5, 2019
Merged
1 task
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@justingluck93 justingluck93

Labels
best practice Not a defect but something that should be improved anyway
Projects
None yet
Milestone
6.2.0
Development

No branches or pull requests
3 participants
@joeljfischer @NicoleYarroch @justingluck93