Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Choice Set Manager uniqueness doesn't take into account loaded cells #2025

Closed
joeljfischer opened this issue Jul 23, 2021 · 0 comments · Fixed by #2019
Closed

Choice Set Manager uniqueness doesn't take into account loaded cells #2025

joeljfischer opened this issue Jul 23, 2021 · 0 comments · Fixed by #2019
Assignees
Labels
bug A defect in the library manager-screen Relating to the manager layer - screen managers

Comments

@joeljfischer
Copy link
Contributor

Bug Report

In the choice set manager, cells that are already loaded on the module need to be taken into account for uniqueness. Currently, it does not, which can lead to clashes when trying to present new cells.

This was found in unit tests and was not attempted to replicate on the head unit.

Reproduction Steps
  1. Using a sub-7.1.0 module
  2. Load a cell on the head unit
  3. Attempt to load a unique cell with identical primary text
Expected Behavior

The new cell has an identifier appended to it

Observed Behavior

The cell fails to load

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: v7.3.0-develop
  • Testing Against: Unit test
Test Case, Sample Code, and / or Example App

n/a

@joeljfischer joeljfischer added bug A defect in the library manager-screen Relating to the manager layer - screen managers labels Jul 23, 2021
@joeljfischer joeljfischer self-assigned this Jul 23, 2021
@joeljfischer joeljfischer linked a pull request Jul 23, 2021 that will close this issue
4 tasks
@joeljfischer joeljfischer mentioned this issue Sep 27, 2021
1 task
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug A defect in the library manager-screen Relating to the manager layer - screen managers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant