Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Security error notifications are missing error description / code #2049

Closed
joeljfischer opened this issue Oct 18, 2021 · 0 comments
Closed
Labels
bug A defect in the library protocol Relating to the protocol layer

Comments

@joeljfischer
Copy link
Contributor

Bug Report

Currently when sending security error messages to core, we do not send JSON / binary error data, but the protocol spec dictates that we should.

Reproduction Steps

n/a easily visible in code

Expected Behavior

Library sends correctly formed error message

Observed Behavior

Library sends malformed error message

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: v7.3.0-RC.1
  • Testing Against: Core v8.0.0-RC.1
Test Case, Sample Code, and / or Example App

SDLProtocol.sdl_serverSecurityFailedMessageWithClientMessageHeader see nil jsonData and nil binaryData

@joeljfischer joeljfischer added bug A defect in the library protocol Relating to the protocol layer labels Oct 18, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug A defect in the library protocol Relating to the protocol layer
Projects
None yet
Development

No branches or pull requests

1 participant