Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Properly end services by using hash ids #661

Closed
joeljfischer opened this issue Jul 24, 2017 · 0 comments
Closed

Properly end services by using hash ids #661

joeljfischer opened this issue Jul 24, 2017 · 0 comments
Labels
bug A defect in the library
Milestone

Comments

@joeljfischer
Copy link
Contributor

Bug Report

Currently, services are not ended with the hash id in the payload. To properly conform to the protocol spec, hash id payloads should be appended to the payload on protocol v4 and less, and by using BSON in v5+. To do this, we will also have to store the hash id.

Expected Behavior

Ending a service should send the proper hash id received in the start service ACK.

Observed Behavior

Ending a service sends a nil payload.

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: v4.6.2
  • Testing Against: n/a
Test Case, Sample Code, and / or Example App

[Paste a link to a PR, gist, or other code that exemplifies this behavior]

@joeljfischer joeljfischer added the bug A defect in the library label Jul 24, 2017
@joeljfischer joeljfischer added this to the 4.7.0 milestone Jul 24, 2017
@joeljfischer joeljfischer modified the milestones: 5.0.0, 4.7.0 Aug 15, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug A defect in the library
Projects
None yet
Development

No branches or pull requests

1 participant