Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Possible crash when there are too few log files to clean up #872

Closed
joeljfischer opened this issue Feb 21, 2018 · 0 comments
Closed

Possible crash when there are too few log files to clean up #872

joeljfischer opened this issue Feb 21, 2018 · 0 comments
Assignees
@joeljfischer
Labels
bug A defect in the library
Milestone
5.2.0

Comments

@joeljfischer
Copy link
Contributor

Bug Report

In SDLLogTargetFile, if there aren't enough files to cleanup, we could run an unsigned integer below zero, causing it to attempt to cleanup too many log files.

Specifically L114 should use an NSInteger so that the for loop doesn't run if there are fewer sortedLogFilePaths than the maxFiles.

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: 5.0+
  • Testing Against: n/a
@joeljfischer joeljfischer added the bug A defect in the library label Feb 21, 2018
@joeljfischer joeljfischer added this to the 5.2.0 milestone Feb 21, 2018
@joeljfischer joeljfischer self-assigned this Feb 21, 2018
@joeljfischer joeljfischer mentioned this issue Feb 21, 2018
Merged
1 task
@joeljfischer joeljfischer mentioned this issue Mar 16, 2018
Merged
2 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@joeljfischer joeljfischer

Labels
bug A defect in the library
Projects
None yet
Milestone
5.2.0
Development

No branches or pull requests
1 participant
@joeljfischer