Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Single tap registered as a pan gesture #879

Closed
1 task done
Lievesley opened this issue Feb 27, 2018 · 4 comments
Closed
1 task done

Single tap registered as a pan gesture #879

Lievesley opened this issue Feb 27, 2018 · 4 comments
Assignees
Labels
bug A defect in the library
Milestone

Comments

@Lievesley
Copy link

Lievesley commented Feb 27, 2018

Bug Report

If the head unit registers a small movement of the finger it is immediately recognised as a pan event instead of a single tap. This means that the iOS SDL SDK never sends our app single tap events.

Reproduction Steps
  1. Perform single tap on head unit display
  2. [SDLTouchManager sdl_handleTouchMoved] is called which sets
    _performingTouchType = SDLPerformingTouchTypePanningTouch;
  3. Single tap delegate method is never called
    [strongSelf.touchEventDelegate touchManager:strongSelf didReceiveSingleTapForView:hitView atPoint:point];
Expected Behavior

There should be a threshold movement level below which pan gestures are not recognised to prevent them interfering with single tap touch events.

Observed Behavior

Pan gesture recogniser prevents single taps from being recognised.

OS & Version Information
  • iOS Version: 11.0.3
  • SDL iOS Version: v5.1
  • Testing Against: Head unit

CLA

@joeljfischer joeljfischer added the bug A defect in the library label Feb 27, 2018
@Lievesley
Copy link
Author

I'm creating a PR that fixes this.

@Lievesley
Copy link
Author

PR is ready for review

@BrettyWhite
Copy link
Contributor

@Lievesley i see you removed the CLA section, before we can merge any code after it is reviewed, that needs to be signed.

@Lievesley
Copy link
Author

@BrettyWhite I just added it again.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug A defect in the library
Projects
None yet
Development

No branches or pull requests

3 participants