The screen manager's soft button manager sends image buttons before images are uploaded

[NicoleYarroch]

Bug Report

The screen manager's soft button manager sends image buttons before said images are uploaded.

The code below:

...
} else if (([self sdl_currentStateHasImages] && ![self sdl_allCurrentStateImagesAreUploaded])
               && (self.softButtonCapabilities ? !self.softButtonCapabilities.imageSupported : YES)) {
...

should be:

...
} else if ((([self sdl_currentStateHasImages] && ![self sdl_allCurrentStateImagesAreUploaded])
               && (self.softButtonCapabilities ? self.softButtonCapabilities.imageSupported.boolValue : NO))
               || (self.softButtonCapabilities ? !self.softButtonCapabilities.imageSupported.boolValue : YES)) {
...

Reproduction Steps

1. Connect app to Core and open SDL app. (App should have at least 1 soft button)

Expected Behavior

If the button has an image not yet uploaded to Core, the manager should wait to send the image button till the image has been successfully uploaded to Core.

Observed Behavior

If the button has an image not yet uploaded to Core, the manager still sends the image button. Core returns an INVALID_DATA error.

OS & Version Information

• iOS Version: n/a
• SDL iOS Version: 5.3
• Testing Against: TDK (SYNC 3)

Test Case, Sample Code, and / or Example App

The SDL_iOS library example app.