Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

When app wants to set audio source directly to XM, should SDL check availability of sirius XM radio? #96

Closed
LitvinenkoIra opened this issue Jul 23, 2018 · 3 comments
Assignees
Labels

Comments

@LitvinenkoIra
Copy link
Contributor

LitvinenkoIra commented Jul 23, 2018

in proposal: https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0182-audio-source-am-fm-xm.md

When app wants to set audio source directly to XM, should SDL check availability of sirius XM radio?
Because now we do not have the corresponding fields in AudioControlCapabilities for new audio sources (AM, FM, XM).

We have param for XM radio (siriusxmRadioAvailable) in RadioControlCapabilities, that was added in proposal number 0160 (https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0160-rc-radio-parameter-update.md)
But in original proposal:

This proposal is an update to a proposal that has not been implemented but is slated for the next release of projects. The proposal is number 0099.

Should we add some new params to AudioControlCapabilities?
something like

                "audioControlCapabilities": [
                {
                        "moduleName": "audio",
                        "sourcesAvailable": [ "AM, FM, XM, DAB" ], // instead of "sourceAvailable": true
                        "volumeAvailable": true,
                        "equalizerAvailable": true,
                        "keepContextAvailable" : true,
                        "equalizerMaxChannelId": 10

                    }
                ]

Or base the implementation of 0182 on 0160 and check AudioControlCapabilities and RadioControlCapabilities also in case when app wants to set audio source directly to XM?

Or is it the responsibility of the HMI to check whether the audio source can be installed? (in case when "sourceAvailable": true in capabilities)

@LitvinenkoIra
Copy link
Contributor Author

@yang1070 and should we add "DAB" to RadioBand enum?

@yang1070
Copy link

@LitvinenkoIra
For now, we don't add any new parameters. sdl just pass the request to HMI, HMI will reject the request if the vehicle does not support XM or DAB radio. SDL HMI implementation can just not support DAB. Your suggestion to change sourceAvailable from Boolean to supported audio source string list is very good. We will consider it, If we choose this option, we need a new proposal for it. I like the idea that SDL check the capability.

@LitvinenkoIra
Copy link
Contributor Author

@yang1070 Got it. Thanks for your response.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants