Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

List bullets don't appear #16

Closed
Kenny2github opened this issue Oct 29, 2017 · 8 comments · Fixed by #18 or #19
Closed

List bullets don't appear #16

Kenny2github opened this issue Oct 29, 2017 · 8 comments · Fixed by #18 or #19
Labels
bug design has-patch help wanted
Milestone
Design

Comments

@Kenny2github
Copy link
Member

Bug

Expected behavior

The "Known issues" section on the website should show bullet points for lists

Actual behavior

The bullet points aren't there

Steps to reproduce

Navigate to https://smelt-modding.github.io
@Kenny2github Kenny2github self-assigned this Oct 29, 2017
@Kenny2github Kenny2github added this to the Design milestone Oct 29, 2017
@Kenny2github
Copy link
Member Author

/cc @VutonDesign

@kerrtravers
Copy link
Contributor

kerrtravers commented Oct 29, 2017 •
edited
Loading

If the usual <ul> isn't working, We could try using copy and paste bullet points for now.

@Kenny2github
Copy link
Member Author

It's a weird CSS bug, I think. I'm still investigating.

@kerrtravers
Copy link
Contributor

@Kenny2github Right 👍

@bluesbroz
Copy link

It is not a bug, you should use <li> instead of <p> inside of <ul>, and since default value for list-style-position is outside, list bullets will be outside of the screen (because all element's padding was reset to 0 ). You can set list-style-position: inside for lists or add padding-left for lists or list items.

Kenny2github added a commit that referenced this issue Nov 11, 2017
@Kenny2github
Use li instead of p and close ul (#16)
c2f14d7
@Kenny2github Kenny2github mentioned this issue Nov 11, 2017
Merged
@Kenny2github
Copy link
Member Author

@bluesbroz thank you! I don't know how it became <p> instead of <li> .-.

@Kenny2github Kenny2github removed their assignment Nov 11, 2017
kerrtravers added a commit that referenced this issue Nov 11, 2017
@kerrtravers
Merge pull request #18 from smelt-modding/fix-tags
b28d947 
Use li instead of p and close ul (#16)
@Kenny2github
Copy link
Member Author

Nope, that pr didn't fix anything!

@Kenny2github Kenny2github reopened this Nov 11, 2017
@Kenny2github Kenny2github mentioned this issue Nov 11, 2017
Merged
@Kenny2github Kenny2github self-assigned this Nov 11, 2017
@Kenny2github
Copy link
Member Author

Yes, that pull worked!

@Kenny2github Kenny2github removed their assignment Nov 11, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug design has-patch help wanted
Milestone
Design
3 participants
@bluesbroz @kerrtravers @Kenny2github