Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reinvention of wheel #6

Open
ojhaujjwal opened this issue May 19, 2014 · 4 comments
Open

Reinvention of wheel #6

ojhaujjwal opened this issue May 19, 2014 · 4 comments

Comments

@ojhaujjwal
Copy link

I recently found Geocoder library which is just too awesome and I discovered that this module can use Geocoder library to remove some duplicate code.

@ojhaujjwal
Copy link
Author

For example, the library already has some entities like:
https://github.com/geocoder-php/Geocoder/blob/master/src/Geocoder/Result/Geocoded.php

@snapshotpl
Copy link
Owner

It looks awesome, however it's idea for another module, becouse this is designed exactly for Maxmind library.

@ojhaujjwal
Copy link
Author

Creating another module will be another reinvention of wheel. I think the module can be changed a little to support Geocoder library. But, that will be BC break. So, you need to tag a major release.

And, you can still use Maxmind library.

@m-cameron
Copy link

Do you have support for IP2Location LITE? It is a free geolocation database up to ZIP code level.

http://lite.ip2location.com

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants