Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature Request] Support base 64 images in dmc.Avatar #374

Closed
pip-install-python opened this issue Oct 28, 2024 · 1 comment · Fixed by #379
Closed

[Feature Request] Support base 64 images in dmc.Avatar #374

pip-install-python opened this issue Oct 28, 2024 · 1 comment · Fixed by #379
Assignees
Labels
good first issue Good for newcomers

Comments

@pip-install-python
Copy link

Was trying to use dcc.Upload with dmc.Avatar but it wouldn't work, reading through the docs of dcc.Upload I noticed it uses a base 64 image that is capable of working with html.Image, attempted to use this base 64 upload in dmc.Image and it works fine, just would be a nice improvement to have dmc.Avatar also support base 64 images.

@AnnMarieW AnnMarieW changed the title dmc.Avatar doesn't work with base 64 images. [Feature Request] Support base 64 images in dmc.Avatar Oct 28, 2024
@AnnMarieW AnnMarieW added the good first issue Good for newcomers label Oct 28, 2024
@AnnMarieW
Copy link
Collaborator

This is caused by an overly restrictive sanitizeUrl.

As with dmc.Image anddmc.BackgroundImage It is not necessary to sanitize the URL of the dmc.Avatar because it renders as an html Img.

See all the details and background discussion in #256

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants