Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use MSnbase objects for storing CAMERA annotations #36

Open
stanstrup opened this issue Apr 2, 2019 · 0 comments
Open

Use MSnbase objects for storing CAMERA annotations #36

stanstrup opened this issue Apr 2, 2019 · 0 comments

Comments

@stanstrup
Copy link
Contributor

stanstrup commented Apr 2, 2019

Related to adding annotation slot in XCMSnExp: sneumann/xcms#295
Related to finding where CAMERA uses XCMS1: #24 (comment)

Instead of CAMERA wrapping around the old xcmsSet object could it make sense to add CAMERA output to an XCMSnExp object instead?
I see two ways to do this:

  1. A dedicated extension of the XCMSnExp object for CAMERA
  2. A generic annotation slot that CAMERA could fill.

We also need to check how much of CAMERAs object really need to be kept around.
Also to consider is if there should be a ProcessHistory kept for the CAMERA processing.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant