Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

v4 planning #86

Open
2 of 11 tasks
sondrelg opened this issue Nov 21, 2022 · 3 comments
Open
2 of 11 tasks

v4 planning #86

sondrelg opened this issue Nov 21, 2022 · 3 comments
Assignees
@JonasKs @sondrelg
Labels
suggestion A feature request/suggestion

Comments

@sondrelg
Copy link
Member

sondrelg commented Nov 21, 2022 •
edited by JonasKs
Loading

  • Make ID generator and validator generic, implement transformer (mirror asgi-correlation-id)
  • Split celery functionality into a separate package
  • Split sentry functionality into a separate package
  • Create extras for both
  • Update license
  • Update test project to handle Django deprecation warnings
  • Update to Poetry v1.2
  • Update classifiers
  • Rework docs (drop sphinx and just have readmes per module?)
  • Remove get_guid and set_guid
  • Create example projects for each feature

Essentially we want to de-bloat the core a little, making it possible to install the core middleware without anything else. It's possible to install the middleware today, without adding celery as a dependency, but the celery code is still contained in the wheel.

There's also some Sentry + Celery logic to consider @JonasKs. Do we put that in its own third package? Something to think about 🤔
@sondrelg sondrelg added the suggestion A feature request/suggestion label Nov 21, 2022
@sondrelg
Copy link
Member Author

How do you feel about the get_guid, set_guid helpers @JonasKs?

@JonasKs
Copy link
Member

JonasKs commented Nov 23, 2022

Get rid of them imo

@sondrelg
Copy link
Member Author

asgi-correlation-id doesn't have a UUID_LENGTH package setting. Instead it's a filter option. Should we do that here as well?

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@JonasKs JonasKs

@sondrelg sondrelg

Labels
suggestion A feature request/suggestion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JonasKs @sondrelg