Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

pull_request and pull_request_review have independent check status #49

Closed
SnowCait opened this issue Feb 23, 2022 · 3 comments · Fixed by #61
Closed

pull_request and pull_request_review have independent check status #49

SnowCait opened this issue Feb 23, 2022 · 3 comments · Fixed by #61
Assignees

Comments

@SnowCait
Copy link
Member

SnowCait commented Feb 23, 2022

Last user approve:
unanimously-approved (pull_request) (outdated)
✔️ unanimously-approved (pull_request_review)
image

This prevents merge.
Outdated check status should disappear.

@SnowCait SnowCait self-assigned this Feb 23, 2022
@SnowCait
Copy link
Member Author

Create a new check status which reflect conclusion.
Let unanimously-approved always success.

@genebean
Copy link

genebean commented Mar 4, 2022

I am just now trying this action out and have run into this. Rerunning a check causes it to pass, but this is less than ideal. Are you already working on a fix?

@SnowCait SnowCait linked a pull request Mar 5, 2022 that will close this issue
@SnowCait
Copy link
Member Author

SnowCait commented Mar 5, 2022

Release v2.0.0.

@genebean
Try it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants