Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

RDB Loader: add alerting for bad warehouse configuration #813

Open
istreeter opened this issue Apr 1, 2022 · 3 comments
Open

RDB Loader: add alerting for bad warehouse configuration #813

istreeter opened this issue Apr 1, 2022 · 3 comments

Comments

@istreeter
Copy link
Contributor

We often see that a warehouse can become mis-configured unexpectedly. For example, a warehouse admin might remove a permission from the loader role, which then prevents the loader from loading a batch. The proposal is for the loader to query the warehouse to discover if everything is configured as expected. For example, check that the table exists; that the loading stage exists; that the loader role is granted sufficient permissions.

The loader is a long-running process, whereas these types of mis-configuration can arise at any time, so it is not sufficient to just check at startup. Instead, I suggest the loader runs these checks immediately after any batch fails to load. If the loader detects a mis-configuration then it should send an alert message.

@chuwy chuwy changed the title Alerting for bad warehouse configuration Snowflake: add alerting for bad warehouse configuration Apr 3, 2022
@chuwy
Copy link
Contributor

chuwy commented Apr 3, 2022

Old Snowflake Loader also had some addition checks, e.g. we need to make sure that every SQS message coming in refers to a folder within configured stage. Otherwise it will be a silent no-op.

@istreeter
Copy link
Contributor Author

Regarding the changed title of this issue: I was thinking we could implement this for all destinations, not just Snowflake. There must be similar examples where a Redshift load fails because the loader does not have the required permissions?

@chuwy
Copy link
Contributor

chuwy commented Apr 4, 2022

Just talked to @stdfalse. He thinks there are two very rare misconfigurations he had noticed:

  1. S3 Bucket permissions (actually common with Snowflake)
  2. Redshift Load role
  3. ...and I also think we can check tables integrity - that they match their expected schema - although this check can be relatively expensive

@spenes spenes added this to the 4.0.0 milestone Apr 26, 2022
@spenes spenes changed the title Snowflake: add alerting for bad warehouse configuration RDB Loader: add alerting for bad warehouse configuration Apr 28, 2022
@istreeter istreeter removed this from the 4.0.0 milestone Jun 14, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants