Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Plan to support Starscream v4 #1258

Closed
patmalt opened this issue Jan 3, 2020 · 20 comments
Closed

Plan to support Starscream v4 #1258

patmalt opened this issue Jan 3, 2020 · 20 comments

Comments

@patmalt
Copy link

patmalt commented Jan 3, 2020

I am experiencing many crashes similar to daltoniam/Starscream#588 in my app. The Starscream maintainers claim in this issue that the crash is fixed due to their rewrite and release of version 4.0.0 (daltoniam/Starscream#653).

This major release is incompatible with the current implementation of socket.io-client-swift and will require changes to this library. Additionally, the new version of Starscream is incompatible with Objective-C.

Is there a desire from socket.io-client-swift to upgrade Starscream to 4.0.0?

@nuclearace
Copy link
Member

I’ll look into upgrading

@patmalt
Copy link
Author

patmalt commented Jan 3, 2020

@patmalt
Copy link
Author

patmalt commented Feb 3, 2020

@nuclearace Any updates on the plan to support v4?

@nuclearace
Copy link
Member

@patmalt I haven't had time to look into yet, but I'd welcome a PR to see what it might look like. Otherwise I don't have a specific timeline. Dropping Obj-c support is something that I'd like to avoid if possible, but wouldn't be dealbreaker I guess.

@NikitaBorodkin
Copy link

Hello!
I'd highly appreciate Starscream v4 support! Any updates so far? :)

@nuclearace
Copy link
Member

I plan to start working on this this weekend. The big decision needed is whether to continue supporting Obj-C in some fashion, or just abandon that compatibility. I think I'll try to maintain that support, but if it gets too ugly, might have to abandon it.

@patmalt
Copy link
Author

patmalt commented May 30, 2020

given the name of this library, it may be appropriate to drop support for objc?

@NikitaBorodkin
Copy link

I really think it's time to drop Obj-C support! :)

@cyambo-talkspace
Copy link

Is there any word on when this will be released?

@patmalt
Copy link
Author

patmalt commented Jun 12, 2020

Is there any way the community could assist with the effort?

@lseidman-talkspace
Copy link

We are getting a significant number of crashes from Starscream v3, and would really appreciate if the library could be updated to use v4. Is there any update on if or when that will happen?

@patmalt
Copy link
Author

patmalt commented Jul 21, 2020

Has there been any progress on this? Is there any way the community can help get us to v4?

@tatealive
Copy link

Hi, I am also experiencing the same crashes with Starscream and eagerly await the update to include v4, would love to know progress. Do let us know if the community can contribute :)

@nuclearace
Copy link
Member

I've been doing some exploration. I've come to the conclusion that the next version of the library will be dropping support for Objective-C. This will allow for a simpler lib and hopefully allow for more swiftier style API.

@patmalt
Copy link
Author

patmalt commented Jul 27, 2020

I have a working implementation here: https://github.com/emersonsoftware/socket.io-client-swift/tree/v4

There are somethings I just commented out that need lots of work. I have not run this code in production either.

@congnd
Copy link

congnd commented Aug 26, 2020

Is there any plan for the next version that will use the newer version of Starscream?

@DHCC-DH
Copy link

DHCC-DH commented Sep 11, 2020

Support Starscream v4

@tatealive
Copy link

Hi @nuclearace , any updates on Starscream v4 support?

@nuclearace
Copy link
Member

fyi #1309

@nuclearace nuclearace pinned this issue Nov 8, 2020
@nuclearace
Copy link
Member

v16.0.0 is been released.

@nuclearace nuclearace unpinned this issue Feb 1, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

8 participants