Skip to content

Commit aead835

Browse files
authored
refactor(sio): make Namespace._fns private (#5196)
Related: #5179
1 parent 029e010 commit aead835

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

packages/socket.io/lib/namespace.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ export class Namespace<
161161
SocketData
162162
>;
163163

164-
protected _fns: Array<
164+
private _fns: Array<
165165
(
166166
socket: Socket<ListenEvents, EmitEvents, ServerSideEvents, SocketData>,
167167
next: (err?: ExtendedError) => void,

packages/socket.io/lib/parent-namespace.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ export class ParentNamespace<
6767
): Namespace<ListenEvents, EmitEvents, ServerSideEvents, SocketData> {
6868
debug("creating child namespace %s", name);
6969
const namespace = new Namespace(this.server, name);
70-
this._fns.forEach((fn) => namespace.use(fn));
70+
this["_fns"].forEach((fn) => namespace.use(fn));
7171
this.listeners("connect").forEach((listener) =>
7272
namespace.on("connect", listener),
7373
);

0 commit comments

Comments
 (0)