[assets] confirm a weak but matching ETag #3485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When handling compression at the proxy server level, the client receives a weak ETag. Weak ETags are prefixed with `W/`, e.g. `W/"2.2.0"`. Upon cache validation we should take care of these too.
|
Hello @darrachequesne, |
|
@darrachequesne - are you the only person that has authoritative control of this project? That's a lot of power. :-) |
|
Hi @darrachequesne! Do you have a moment to take a look at this PR please? Thanks in advance! |
darrachequesne
pushed a commit
that referenced
this pull request
Jan 14, 2021
When handling compression at the proxy server level, the client receives a weak ETag. Weak ETags are prefixed with `W/`, e.g. `W/"2.2.0"`. Upon cache validation we should take care of these too.
darrachequesne
pushed a commit
that referenced
this pull request
Jan 15, 2021
When handling compression at the proxy server level, the client receives a weak ETag. Weak ETags are prefixed with `W/`, e.g. `W/"2.2.0"`. Upon cache validation we should take care of these too. Reference: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/ETag
|
Merged as 161091d (finally!) and included in |
This was referenced Mar 10, 2021
Bump socket.io from 2.3.0 to 4.0.0 in /filiikot/rootfs/opt/filiikot
filii-lamberti/addon-filiikot#87
Closed
Closed
This was referenced Mar 11, 2021
dzad
pushed a commit
to dzad/socket.io
that referenced
this pull request
May 29, 2023
When handling compression at the proxy server level, the client receives a weak ETag. Weak ETags are prefixed with `W/`, e.g. `W/"2.2.0"`. Upon cache validation we should take care of these too. Reference: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/ETag
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When handling compression at the proxy server level, the client receives a weak ETag.
Weak ETags are prefixed with
W/, e.g.W/"2.2.0".Upon cache validation we should take care of these too.
The kind of change this PR does introduce
Current behaviour
Server responds with a 200 + full payload for a weak but matching etag.
New behaviour
Server responds with 304.
Other information (e.g. related issues)
See linked rfc https://tools.ietf.org/html/rfc7232#section-2.3