Event will get wrong ProviderInfo when use reuses client transport.

[ujjboy]

Describe the bug

ClientSyncReceiveEvent may get the wrong ProviderInfo when use reuses client transport with the same remote address.

Expected behavior

When two consumer config (for example A and B) get the same address which provides this A and B two services. They will use same client transport.

And after invoke, It will post ClientSyncReceiveEvent with provider info to the event bus.

Actual behavior

Now in BoltClientTransport, code like this:

if (EventBus.isEnable(ClientSyncReceiveEvent.class)) {
    EventBus.post(new ClientSyncReceiveEvent(transportConfig.getConsumerConfig(),
         transportConfig.getProviderInfo(), request, response, throwable));
}

If this client transport is initial for A, transportConfig.getProviderInfo() is provider info of A, and will be reused by B. When invoke by B, transportConfig.getProviderInfo() will also return provider info of A, It needs fixing.

Environment

• SOFARPC version: 5.3.2

[leizhiyuan]

one possible solution

when generate map key,we add consumerConfig interface and uniqId

com.alipay.sofa.rpc.transport.ReusableClientTransportHolder#getClientTransport

@Override
    public ClientTransport getClientTransport(ClientTransportConfig config) {
        String key = getAddr(config); //here we make key unique
        ClientTransport transport = clientTransportMap.get(key);
        if (transport == null) {
            transport = ExtensionLoaderFactory.getExtensionLoader(ClientTransport.class)
                .getExtension(config.getContainer(),
                    new Class[] { ClientTransportConfig.class },
                    new Object[] { config });
            ClientTransport oldTransport = clientTransportMap.putIfAbsent(key, transport); // 保存唯一长连接
            if (oldTransport != null) {
                if (LOGGER.isWarnEnabled()) {
                    LOGGER.warn("Multiple threads init ClientTransport with same key:" + key);
                }
                transport.destroy(); //如果同时有人插入，则使用第一个
                transport = oldTransport;
            }
        }