Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Unify collapses #81

Merged
merged 8 commits into from
Feb 13, 2025
Merged

Unify collapses #81

merged 8 commits into from
Feb 13, 2025

Conversation

GuzekAlan
Copy link
Contributor

No description provided.

@GuzekAlan GuzekAlan requested a review from kraleppa February 12, 2025 11:36
@@ -0,0 +1,87 @@
defmodule LiveDebugger.Components.ElixirDisplay do
@moduledoc """
This module provides a LiveComponent to display a tree of terms.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This module provides a LiveComponent to display a tree of terms.
This module provides a component to display a tree of terms.

Copy link
Member

@kraleppa kraleppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some differences when it comes to Elixir display:

  • Missing ... in { ... }
  • Some whitespace are missing

Before this PR
Screenshot 2025-02-12 at 17 25 28

After
Screenshot 2025-02-12 at 17 24 40

@GuzekAlan GuzekAlan requested a review from kraleppa February 12, 2025 17:18
@GuzekAlan GuzekAlan merged commit 0ca79eb into main Feb 13, 2025
1 check passed
@GuzekAlan GuzekAlan deleted the unify-collapses branch February 13, 2025 09:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants