Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Optimize VertxServerRequest.uri #3550

Closed
kciesielski opened this issue Feb 29, 2024 · 0 comments · Fixed by #3590
Closed

Optimize VertxServerRequest.uri #3550

kciesielski opened this issue Feb 29, 2024 · 0 comments · Fixed by #3590
Milestone
Performance

Comments

@kciesielski
Copy link
Member

Similarly to Netty (see #3547), VertServerRequest calls Uri.unsafeParse which is somewhat expensive. Below is a flamegraph from profiling the SimpleGet and SimpleGetMultiRoute performance tests:

image
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Performance
Development

Successfully merging a pull request may close this issue.

Improve showShort to avoid parsing Uri softwaremill/tapir
1 participant
@kciesielski