replaced dyn and box with second match

Author: ananas-block

programs/bpf_loader/src/syscalls/mod.rs

@@ -1676,20 +1676,17 @@ declare_syscall!(
         memory_mapping: &mut MemoryMapping,
     ) -> Result<u64, EbpfError> {
         use solana_sdk::alt_bn128::prelude::{ALT_BN128_ADD, ALT_BN128_MUL, ALT_BN128_PAIRING};
-        type DynAltBnFunction = Box<dyn for<'r> Fn(&'r [u8]) -> Result<Vec<u8>, AltBn128Error>>;
 
         let budget = invoke_context.get_compute_budget();
 
-        let (cost, output, calculation): (u64, usize, DynAltBnFunction) = match group_op {
+        let (cost, output): (u64, usize) = match group_op {
             ALT_BN128_ADD => (
                 budget.alt_bn128_addition_cost,
                 ALT_BN128_ADDITION_OUTPUT_LEN,
-                Box::new(alt_bn128_addition),
             ),
             ALT_BN128_MUL => (
                 budget.alt_bn128_multiplication_cost,
                 ALT_BN128_MULTIPLICATION_OUTPUT_LEN,
-                Box::new(alt_bn128_multiplication),
             ),
             ALT_BN128_PAIRING => {
                 let ele_len = input_size.saturating_div(ALT_BN128_PAIRING_ELEMENT_LEN as u64);
@@ -1703,16 +1700,13 @@ declare_syscall!(
                     .saturating_add(budget.sha256_base_cost)
                     .saturating_add(input_size)
                     .saturating_add(ALT_BN128_PAIRING_OUTPUT_LEN as u64);
-                (
-                    cost,
-                    ALT_BN128_PAIRING_OUTPUT_LEN,
-                    Box::new(alt_bn128_pairing),
-                )
+                (cost, ALT_BN128_PAIRING_OUTPUT_LEN)
             }
             _ => {
                 return Err(SyscallError::InvalidAttribute.into());
             }
         };
+
         invoke_context.get_compute_meter().consume(cost)?;
 
         let input = translate_slice::<u8>(
@@ -1731,7 +1725,16 @@ declare_syscall!(
             invoke_context.get_check_size(),
         )?;
 
-        let result_point = match (*calculation)(input) {
+        let calculation = match group_op {
+            ALT_BN128_ADD => alt_bn128_addition,
+            ALT_BN128_MUL => alt_bn128_multiplication,
+            ALT_BN128_PAIRING => alt_bn128_pairing,
+            _ => {
+                return Err(SyscallError::InvalidAttribute.into());
+            }
+        };
+
+        let result_point = match calculation(input) {
             Ok(result_point) => result_point,
             Err(e) => {
                 return Ok(e.into());