This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
compute_bank_stats needs to return newly computed ForkStats #8608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvines
reviewed
Mar 4, 2020
mvines
previously approved these changes
Mar 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #8608 +/- ##
======================================
Coverage 80.0% 80.1%
======================================
Files 256 257 +1
Lines 55730 55797 +67
======================================
+ Hits 44604 44696 +92
+ Misses 11126 11101 -25 |
mergify bot
pushed a commit
that referenced
this pull request
Mar 4, 2020
* Fix broken confirmation, add test (cherry picked from commit f23dc11)
carllin
added a commit
that referenced
this pull request
Mar 4, 2020
* Fix broken confirmation, add test (cherry picked from commit f23dc11)
carllin
added a commit
that referenced
this pull request
Mar 4, 2020
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Due to a bad merge,
compute_bank_statsdoes not currently return the newly computed ForkStats soconfirm_forksdoes not run, so no confirmations will be reported.Summary of Changes
Fix and add test
Fixes #