This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Expose executable and rent_epoch in AccountInfo #8619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8619 +/- ##
========================================
Coverage ? 80%
========================================
Files ? 256
Lines ? 55751
Branches ? 0
========================================
Hits ? 44610
Misses ? 11141
Partials ? 0 |
jackcmay
commented
Mar 4, 2020
| @@ -170,12 +170,14 @@ SOL_FN_PREFIX bool SolPubkey_same(const SolPubkey *one, const SolPubkey *two) { | |||
| */ | |||
| typedef struct { | |||
| SolPubkey *key; /** Public key of the account */ | |||
| bool is_signer; /** Transaction was signed by this account's key? */ | |||
There was a problem hiding this comment.
@mvines Any opposition to this structure re-org, saves 8 bytes :-)
There was a problem hiding this comment.
nope! We prolly ought to get this on 1.0.x for TdS
mergify bot
pushed a commit
that referenced
this pull request
Mar 4, 2020
(cherry picked from commit 25df95b)
solana-grimes
added a commit
that referenced
this pull request
Mar 4, 2020
This was referenced Feb 4, 2023
This was referenced Feb 24, 2023
Open
Open
Open
This was referenced Feb 28, 2023
Open
This was referenced Mar 1, 2023
This was referenced Apr 3, 2023
This was referenced Apr 5, 2023
Open
Open
Open
This was referenced Apr 8, 2023
Open
This was referenced Apr 10, 2023
This was referenced Apr 10, 2023
Open
Open
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
AccountInfodoes not expose the same members asAccount, namelyexecutableandrent_epoch.One place this becomes an issue is when doing cross-program-invocations where the program's accounts are passed to another program from within the program.
Summary of Changes
Expose
executableandrent_epochinAccountInfoFixes #