Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bug? No login button on https://playground.solidjs.com/ #168

Open
birkskyum opened this issue Mar 25, 2024 · 2 comments
Open

Bug? No login button on https://playground.solidjs.com/ #168

birkskyum opened this issue Mar 25, 2024 · 2 comments

Comments

@birkskyum
Copy link
Contributor

birkskyum commented Mar 25, 2024

I don't remember if there should be a Login button in the deployed version.

I see it locally, both in dev and in build+start.

Screenshot 2024-03-25 at 05 27 48
@milomg
Copy link
Member

milomg commented Mar 25, 2024

I've deployed the legacy branch which disables login and supports old hashes

Cc @davedbase, do you remember why we turned off login? Something to do with sharing anonymous repls not working on the backend?

@Tommypop2
Copy link
Contributor

@modderme123 I seem to remember the fact that iframes can escape their sandboxing being an issue here, where a user could send a link with malicious playground code which steals their session token and sends to a backend somewhere.
Is this still an issue?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants