Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Incorrect file extensions published to npm #178

Open
NullVoxPopuli opened this issue Jul 24, 2024 · 3 comments
Open

Incorrect file extensions published to npm #178

NullVoxPopuli opened this issue Jul 24, 2024 · 3 comments

Comments

@NullVoxPopuli
Copy link

Just saw
image

(I'm poking around!) :D

And there is non-JS syntax in here.

I believe that should be compiled away yeah?
(or if the consuming project is responsible for further-compiling the library, the file extension should be jsx, yeah?)

thanks!
(lemme know if I misunderstand something! <3)

@NullVoxPopuli
Copy link
Author

NullVoxPopuli commented Jul 24, 2024

omg, I missed that this is all in a string.
everything is fine.

MORE COFFEE

@NullVoxPopuli
Copy link
Author

NullVoxPopuli commented Jul 24, 2024

actually no, I think I still have a question about use of jsx in a published package:

image

This file doesn't need to be jsx tho 🤔
image

@NullVoxPopuli NullVoxPopuli reopened this Jul 24, 2024
@milomg
Copy link
Member

milomg commented Aug 11, 2024

I believe we mark the root as jsx so that vite compiles the package with babel (otherwise we've had problems with it skipping the SolidJS transform for this package)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants