Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Audit / Versionning #12

Closed
rande opened this issue Dec 12, 2011 · 9 comments
Closed

Audit / Versionning #12

rande opened this issue Dec 12, 2011 · 9 comments

Comments

@rande
Copy link
Member

rande commented Dec 12, 2011

Hello,

I just add a support for Audit/Versionning, I have started to add interfaces in the AdminBundle and the implementation in DoctrineORMAdminBundle. I am not sure if the interface can match the PHPCR requirements, can you please have a look the the following comments and provides any comments you might have.

Thanks.

@dbu
Copy link
Contributor

dbu commented Dec 12, 2011

we plan to add versioning to phpcr-odm soon, so this comes really at the right time. the planned interface will look something like this:
https://github.com/doctrine/phpcr-odm/wiki/Versioning

i glanced over your code and it looks like we can do this. things i wonder:

  • can one remove an old version? (doable with phpcr, use case: admin removes a version with seriously illegal content or similar)
  • can one edit old versions? (not supported by phpcr)
  • creating new versions is out of scope here, right?

@rande
Copy link
Member Author

rande commented Dec 12, 2011

  • can one remove an old version? (doable with phpcr, use case: admin removes a version with seriously illegal content or si
    milar)
    => not yet, but it is something we can easily add
  • can one edit old versions? (not supported by phpcr)
    => not possible, but the way the DoctrineORM is built it will be possible to load an entity into the Edit Form and then save it again (new revision then)
  • creating new versions is out of scope here, right?
    => the revisions is created every time an object is saved. So it is not a user decision. Not sure if the AuditEntity can be tweaked to be disabled depends on a specific context.

@dbu
Copy link
Contributor

dbu commented Dec 12, 2011

  • remove old version: its a nice-to-have for me but there is this use case i mentioned...
  • with phpcr you can load the data as it was at some revision, so this workflow should work
  • ah, ok. well, this is really application specific. in phpcr you explicitly tell it to create a new version but the phpcr-adminbundle glue code can easily do that.

@rande
Copy link
Member Author

rande commented Dec 12, 2011

I guess, there is a difference between audit and revision ... for now the AdminBundle try to solve the Audit one : tracking every changes on an object.

@beberlei : maybe the AuditEntity can be altered to match the Audit (Quality Control) and the Revision (User Content) requirements.

@dbu
Copy link
Contributor

dbu commented Feb 7, 2012

versioning support is now available in phpcr-odm doctrine/phpcr-odm#96 (when using jackalope-jackrabbit, that is ;-)

@dbu
Copy link
Contributor

dbu commented Feb 7, 2012

is #27 a duplicate of this issue?

@INHack20
Copy link

INHack20 commented Aug 3, 2015

+1 +1 +1

will support versioning of documents?
symfony an alternative to version documents?

@dbu
Copy link
Contributor

dbu commented Aug 3, 2015

@INHack20 doctrine phpcr-odm supports versioning. but nobody yet built support for the functionality into sonata admin. maybe this can simply be an admin extension, but probably direct support in sonata admin would allow a better user experience.

versioning is explained at http://doctrine-phpcr-odm.readthedocs.org/en/latest/reference/versioning.html

@core23
Copy link
Member

core23 commented Mar 15, 2019

This issue is very old. Can you please check this against the latest stable / master version?

Feel free to reopen, if the error still exists.

A PR would be welcome if you reopen this issue.

@core23 core23 closed this as completed Mar 15, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants