Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[yang] Support new device type #10487

Closed
ganglyu opened this issue Apr 7, 2022 · 0 comments · Fixed by #10488
Closed

[yang] Support new device type #10487

ganglyu opened this issue Apr 7, 2022 · 0 comments · Fixed by #10488
Labels
YANG YANG model related changes

Comments

@ganglyu
Copy link
Contributor

ganglyu commented Apr 7, 2022

Description

minigraph has introduced new device type: BmcMgmtToRRouter
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-config-engine/minigraph.py#L40
Yang models does not support this pattern:
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-device_metadata.yang#L88-L93

Steps to reproduce the issue:

  1. Run unit test for sonic-config-engine
  2. Check output device type

Describe the results you received:

BmcMgmtToRRouter can't pass yang validation.

Describe the results you expected:

BmcMgmtToRRouter should pass yang validation.

Output of show version:

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

@ganglyu ganglyu added the YANG YANG model related changes label Apr 7, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
YANG YANG model related changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant