Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[backend] Loading backend ACL removes the ACL rules loaded previously #17552

Closed
bingwang-ms opened this issue Dec 19, 2023 · 0 comments · Fixed by #17553
Closed

[backend] Loading backend ACL removes the ACL rules loaded previously #17552

bingwang-ms opened this issue Dec 19, 2023 · 0 comments · Fixed by #17553
Assignees
Labels
MSFT Triaged this issue has been triaged

Comments

@bingwang-ms
Copy link
Contributor

Description

PR #14229 added a service for loading backend ACL rules. There is an issue in below code in backend_acl.py.

if os.path.isfile(BACKEND_ACL_FILE):
run_command(['acl-loader', 'update', 'incremental', BACKEND_ACL_FILE])

Because table_name is not specified when calling acl-loader, the ACL rules loaded previously will be cleared.

Steps to reproduce the issue:

  1. Run config load_minigraph
  2. Check ACL rules on the device

Describe the results you received:

The ACL rules should not be cleared by backend-acl service.

Describe the results you expected:

Output of show version:

SONiC Software Version: SONiC.20201231.118
Distribution: Debian 10.13
Kernel: 4.19.0-12-2-amd64
Build commit: 2e55bdeb8c
Build date: Wed Dec 13 00:14:17 UTC 2023
Built by: cloudtest@36ffe988c000000

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
MSFT Triaged this issue has been triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants