Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support building crates that use resolver 2 #133

Closed
Maldron opened this issue Jul 27, 2021 · 1 comment
Closed

Support building crates that use resolver 2 #133

Maldron opened this issue Jul 27, 2021 · 1 comment

Comments

@Maldron
Copy link

Maldron commented Jul 27, 2021

If a crate (or any of its dependencies) has opted in to resolver 2, it won't currently build with dinghy. The 2021 edition will make resolver 2 the default for new crates (rust-lang/cargo#9048), so this will probably become a widespread issue over time.

To reproduce, create a new empty library like cargo new resolver_2_test --lib, then add resolver = "2" to resolver_2_test/Cargo.toml. Then run dinghy as normal with cargo dinghy -d rust_test_simulator test, and you'll get the following error:

[2021-07-27T20:59:01Z ERROR cargo_dinghy] failed to parse manifest at `/Users/.../resolver_2_test/Cargo.toml`

    Caused by:
        feature `resolver` is required

        this Cargo does not support nightly features, but if you
        switch to nightly channel you can add
        `cargo-features = ["resolver"]` to enable this feature
@kali kali mentioned this issue Jul 28, 2021
@Maldron
Copy link
Author

Maldron commented Jul 28, 2021

Fixed in #134. Thanks @kali!

@Maldron Maldron closed this as completed Jul 28, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant