Skip to content
This repository has been archived by the owner on Sep 14, 2021. It is now read-only.

Provide good env var defaults in the binary instead of Dockerfile #21

Open
emidoots opened this issue May 31, 2019 · 1 comment
Open

Comments

@emidoots
Copy link
Member

emidoots commented May 31, 2019

We should move all env vars from the Dockerfile into the binary itself so that consumers using just the binary (e.g. Sourcegraph) do not have to separately maintain their own list of env vars to configure Rocket.

Should be as simple as setting them if not already set.

@emidoots
Copy link
Member Author

emidoots commented Oct 3, 2019

Now that we have http-server-stabilizer in use, too, it would make more sense to use a shell script instead. This would allow us to more easily get http-server-stabilizer working in sourcegraph/server deployments, as well.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant