Fix rvm install

[xdissent]

A better solution to PR 82: #82

[smdern]

you can just specify bash here and not have to include line 71, interpreter 'bash'

[xdissent]

Oh, bash instead of script and interpreter. You're totally right. I'll update it, thanks.

[smdern]

Tried out your branch and it works :) Thanks for sorting this out.

[glappen]

Just tested xdissent's branch and it works - please pull it in!

[xdissent]

It looks like RVM is moving to https://rvm.io/ and the official install command has now lost the process substitution that was breaking the chef recipe: curl -L get.rvm.io | bash -s stable. I'll try updating to the new url/command and see how that works.

[griff]

This fix doesn't actually fix the problem it only ignores it.

Bash defaults to ignoring the exit code of any programs it runs so when the script is run and it exits with status 1 the changeset in this pull request simply ignores that value. This is problematic because when the install actually fails it is not reported as such.

If you enable the option for bash to quit when any program returns an error:
set -o errexit
at the start of the code you will see what I am talking about.

The actual problem with the install script is caused by rvm trying to use colors for its terminal output which fails because it hasn't got a real terminal. To fix it you can set the TERM env var to dumb

[xdissent]

@griff got it. Fixed, plus changed to new official installer command and URL.

[fnichol]

Great catch and thanks everyone including @elhu from #82 for the testing and refining. Looks like we should get a stable release out the door now...

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.